From 879348c120e72aee2f8f9d50ee0b764627ab3607 Mon Sep 17 00:00:00 2001
From: Santo Cariotti <santo@dcariotti.me>
Date: Thu, 5 Sep 2024 14:43:24 +0200
Subject: Fixs with clippy

---
 src/graphql/mutation.rs           | 2 +-
 src/graphql/types/jwt.rs          | 2 +-
 src/graphql/types/notification.rs | 6 +++++-
 src/graphql/types/user.rs         | 6 +++---
 4 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/graphql/mutation.rs b/src/graphql/mutation.rs
index dfffad8..6e0a265 100644
--- a/src/graphql/mutation.rs
+++ b/src/graphql/mutation.rs
@@ -284,7 +284,7 @@ impl Mutation {
 
                 let mut notification_ids = vec![];
                 for id in &position_ids {
-                    let notification = notification::Notification::new(client, alert.id, *id)
+                    let notification = notification::Notification::insert_db(client, alert.id, *id)
                         .await
                         .unwrap();
                     notification_ids.push(notification);
diff --git a/src/graphql/types/jwt.rs b/src/graphql/types/jwt.rs
index df815aa..d27c6c3 100644
--- a/src/graphql/types/jwt.rs
+++ b/src/graphql/types/jwt.rs
@@ -111,7 +111,7 @@ where
                             }
                             _ => {
                                 eprintln!("{err:?}");
-                                return AppError::Unauthorized;
+                                AppError::Unauthorized
                             }
                         })?;
 
diff --git a/src/graphql/types/notification.rs b/src/graphql/types/notification.rs
index a8c327e..6a14d71 100644
--- a/src/graphql/types/notification.rs
+++ b/src/graphql/types/notification.rs
@@ -20,7 +20,11 @@ pub struct Notification {
 impl Notification {
     /// Create a new notification into the database from an alert_id and a position_id.
     /// Returns the new ID.
-    pub async fn new(client: &Client, alert_id: i32, position_id: i32) -> Result<i32, AppError> {
+    pub async fn insert_db(
+        client: &Client,
+        alert_id: i32,
+        position_id: i32,
+    ) -> Result<i32, AppError> {
         match client
             .query(
                 "INSERT INTO notifications(alert_id, position_id)
diff --git a/src/graphql/types/user.rs b/src/graphql/types/user.rs
index 09404ec..798fd8c 100644
--- a/src/graphql/types/user.rs
+++ b/src/graphql/types/user.rs
@@ -32,11 +32,11 @@ impl User {
     }
 
     async fn name(&self) -> String {
-        self.name.clone().unwrap_or(String::default())
+        self.name.clone().unwrap_or_default()
     }
 
     async fn address(&self) -> String {
-        self.address.clone().unwrap_or(String::default())
+        self.address.clone().unwrap_or_default()
     }
 
     async fn notification_token(&self) -> String {
@@ -150,7 +150,7 @@ pub async fn get_user_by_id<'ctx>(ctx: &Context<'ctx>, id: i32) -> Result<User,
                 })
                 .collect();
 
-            if users.len() == 0 {
+            if users.is_empty() {
                 return Err("Not found".to_string());
             }
 
-- 
cgit v1.2.3-18-g5258