From 06671f5aed68753435a762bc3be43e83094156d1 Mon Sep 17 00:00:00 2001
From: geno <gabriele.genovese2@studio.unibo.it>
Date: Wed, 26 Jun 2024 14:53:05 +0200
Subject: exercise 1 completed

1.b now works
1.c implened error for "function takes N positional arguments but M were given"
---
 src/ast/nodes/ParamdefNode.java | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

(limited to 'src/ast/nodes/ParamdefNode.java')

diff --git a/src/ast/nodes/ParamdefNode.java b/src/ast/nodes/ParamdefNode.java
index 265b6b6..5164537 100644
--- a/src/ast/nodes/ParamdefNode.java
+++ b/src/ast/nodes/ParamdefNode.java
@@ -1,24 +1,32 @@
 package ast.nodes;
 
-import java.util.ArrayList;
-
 import ast.types.*;
-import semanticanalysis.*;
+import java.util.ArrayList;
+import semanticanalysis.SemanticError;
+import semanticanalysis.SymbolTable;
 
 /**
  * Node for the `paramdef` statement of the grammar. Extends the `AtomNode`
  * class.
  */
 public class ParamdefNode extends AtomNode {
+
     public ParamdefNode(String val) {
         super(val);
     }
 
     @Override
     public ArrayList<SemanticError> checkSemantics(SymbolTable ST, int _nesting) {
-        ST.insert(this.getId(), this.typeCheck(), _nesting, "");
+        var errors = new ArrayList<SemanticError>();
+        String paramName = this.getId();
+
+        if (!ST.top_lookup(paramName)) {
+            ST.insert(paramName, this.typeCheck(), _nesting, "");
+        } else {
+            errors.add(new SemanticError("Duplicate argument '" + paramName + "' in function definition."));
+        }
 
-        return new ArrayList<SemanticError>();
+        return errors;
     }
 
     // FIXME: it should returns the param' type
-- 
cgit v1.2.3-18-g5258