From 6bdf1fc6c1b7afe18ffcae05f8fb11eca0f51258 Mon Sep 17 00:00:00 2001
From: Santo Cariotti <santo@dcariotti.me>
Date: Tue, 25 Jun 2024 11:33:41 +0200
Subject: wip

---
 src/ast/nodes/ParamdefNode.java | 7 +++++++
 1 file changed, 7 insertions(+)

(limited to 'src/ast/nodes/ParamdefNode.java')

diff --git a/src/ast/nodes/ParamdefNode.java b/src/ast/nodes/ParamdefNode.java
index 481282e..3ad82dd 100644
--- a/src/ast/nodes/ParamdefNode.java
+++ b/src/ast/nodes/ParamdefNode.java
@@ -11,6 +11,13 @@ public class ParamdefNode extends AtomNode {
         super(val);
     }
 
+    @Override
+    public ArrayList<SemanticError> checkSemantics(SymbolTable ST, int _nesting) {
+        ST.insert(this.getId(), this.typeCheck(), _nesting, "");
+
+        return new ArrayList<SemanticError>();
+    }
+
     // FIXME: it should returns the param' type
     @Override
     public Type typeCheck() {
-- 
cgit v1.2.3-18-g5258


From da554f4281da45a22f7101f26cfdf274149c7966 Mon Sep 17 00:00:00 2001
From: L0P0P <grassoemanuele@live.com>
Date: Tue, 25 Jun 2024 11:41:32 +0200
Subject: Fixed import problems

---
 src/ast/nodes/ParamdefNode.java | 3 +++
 1 file changed, 3 insertions(+)

(limited to 'src/ast/nodes/ParamdefNode.java')

diff --git a/src/ast/nodes/ParamdefNode.java b/src/ast/nodes/ParamdefNode.java
index 3ad82dd..265b6b6 100644
--- a/src/ast/nodes/ParamdefNode.java
+++ b/src/ast/nodes/ParamdefNode.java
@@ -1,6 +1,9 @@
 package ast.nodes;
 
+import java.util.ArrayList;
+
 import ast.types.*;
+import semanticanalysis.*;
 
 /**
  * Node for the `paramdef` statement of the grammar. Extends the `AtomNode`
-- 
cgit v1.2.3-18-g5258


From 06671f5aed68753435a762bc3be43e83094156d1 Mon Sep 17 00:00:00 2001
From: geno <gabriele.genovese2@studio.unibo.it>
Date: Wed, 26 Jun 2024 14:53:05 +0200
Subject: exercise 1 completed

1.b now works
1.c implened error for "function takes N positional arguments but M were given"
---
 src/ast/nodes/ParamdefNode.java | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

(limited to 'src/ast/nodes/ParamdefNode.java')

diff --git a/src/ast/nodes/ParamdefNode.java b/src/ast/nodes/ParamdefNode.java
index 265b6b6..5164537 100644
--- a/src/ast/nodes/ParamdefNode.java
+++ b/src/ast/nodes/ParamdefNode.java
@@ -1,24 +1,32 @@
 package ast.nodes;
 
-import java.util.ArrayList;
-
 import ast.types.*;
-import semanticanalysis.*;
+import java.util.ArrayList;
+import semanticanalysis.SemanticError;
+import semanticanalysis.SymbolTable;
 
 /**
  * Node for the `paramdef` statement of the grammar. Extends the `AtomNode`
  * class.
  */
 public class ParamdefNode extends AtomNode {
+
     public ParamdefNode(String val) {
         super(val);
     }
 
     @Override
     public ArrayList<SemanticError> checkSemantics(SymbolTable ST, int _nesting) {
-        ST.insert(this.getId(), this.typeCheck(), _nesting, "");
+        var errors = new ArrayList<SemanticError>();
+        String paramName = this.getId();
+
+        if (!ST.top_lookup(paramName)) {
+            ST.insert(paramName, this.typeCheck(), _nesting, "");
+        } else {
+            errors.add(new SemanticError("Duplicate argument '" + paramName + "' in function definition."));
+        }
 
-        return new ArrayList<SemanticError>();
+        return errors;
     }
 
     // FIXME: it should returns the param' type
-- 
cgit v1.2.3-18-g5258


From eb7fb04d2dfadd004fa86f28da42681e0038df06 Mon Sep 17 00:00:00 2001
From: geno <gabriele.genovese2@studio.unibo.it>
Date: Thu, 27 Jun 2024 18:20:34 +0200
Subject: left, right = 1, 2 assignment covered

sfaccimm ho fatto refactoring dell exprlist
---
 src/ast/nodes/ParamdefNode.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/ast/nodes/ParamdefNode.java')

diff --git a/src/ast/nodes/ParamdefNode.java b/src/ast/nodes/ParamdefNode.java
index 5164537..adadf72 100644
--- a/src/ast/nodes/ParamdefNode.java
+++ b/src/ast/nodes/ParamdefNode.java
@@ -12,7 +12,7 @@ import semanticanalysis.SymbolTable;
 public class ParamdefNode extends AtomNode {
 
     public ParamdefNode(String val) {
-        super(val);
+        super(val, null);
     }
 
     @Override
-- 
cgit v1.2.3-18-g5258


From afff6a80cd58f7787efa1398f7c8cbdce8989323 Mon Sep 17 00:00:00 2001
From: geno <gabriele.genovese2@studio.unibo.it>
Date: Sun, 30 Jun 2024 13:36:37 +0200
Subject: fixed warnings, better formatting, final added where possible

---
 src/ast/nodes/ParamdefNode.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/ast/nodes/ParamdefNode.java')

diff --git a/src/ast/nodes/ParamdefNode.java b/src/ast/nodes/ParamdefNode.java
index adadf72..6cdb2d0 100644
--- a/src/ast/nodes/ParamdefNode.java
+++ b/src/ast/nodes/ParamdefNode.java
@@ -17,7 +17,7 @@ public class ParamdefNode extends AtomNode {
 
     @Override
     public ArrayList<SemanticError> checkSemantics(SymbolTable ST, int _nesting) {
-        var errors = new ArrayList<SemanticError>();
+        var errors = new ArrayList();
         String paramName = this.getId();
 
         if (!ST.top_lookup(paramName)) {
-- 
cgit v1.2.3-18-g5258