From 6bdf1fc6c1b7afe18ffcae05f8fb11eca0f51258 Mon Sep 17 00:00:00 2001
From: Santo Cariotti <santo@dcariotti.me>
Date: Tue, 25 Jun 2024 11:33:41 +0200
Subject: wip

---
 src/ast/nodes/ParamlistNode.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/ast/nodes/ParamlistNode.java')

diff --git a/src/ast/nodes/ParamlistNode.java b/src/ast/nodes/ParamlistNode.java
index 144eb13..a097c19 100644
--- a/src/ast/nodes/ParamlistNode.java
+++ b/src/ast/nodes/ParamlistNode.java
@@ -21,7 +21,7 @@ public class ParamlistNode implements Node {
         ArrayList<SemanticError> errors = new ArrayList<SemanticError>();
 
         for (var param : params) {
-            errors.addAll(param.checkSemantics(ST, _nesting));
+            errors.addAll(param.checkSemantics(ST, _nesting + 1));
         }
 
         return errors;
-- 
cgit v1.2.3-18-g5258


From 9e6c17cb44bc165e315ec039a0e09183716d2037 Mon Sep 17 00:00:00 2001
From: L0P0P <grassoemanuele@live.com>
Date: Wed, 26 Jun 2024 11:44:58 +0200
Subject: Semantic check for function declaration and function invocation

---
 src/ast/nodes/ParamlistNode.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/ast/nodes/ParamlistNode.java')

diff --git a/src/ast/nodes/ParamlistNode.java b/src/ast/nodes/ParamlistNode.java
index a097c19..144eb13 100644
--- a/src/ast/nodes/ParamlistNode.java
+++ b/src/ast/nodes/ParamlistNode.java
@@ -21,7 +21,7 @@ public class ParamlistNode implements Node {
         ArrayList<SemanticError> errors = new ArrayList<SemanticError>();
 
         for (var param : params) {
-            errors.addAll(param.checkSemantics(ST, _nesting + 1));
+            errors.addAll(param.checkSemantics(ST, _nesting));
         }
 
         return errors;
-- 
cgit v1.2.3-18-g5258


From 06671f5aed68753435a762bc3be43e83094156d1 Mon Sep 17 00:00:00 2001
From: geno <gabriele.genovese2@studio.unibo.it>
Date: Wed, 26 Jun 2024 14:53:05 +0200
Subject: exercise 1 completed

1.b now works
1.c implened error for "function takes N positional arguments but M were given"
---
 src/ast/nodes/ParamlistNode.java | 5 +++++
 1 file changed, 5 insertions(+)

(limited to 'src/ast/nodes/ParamlistNode.java')

diff --git a/src/ast/nodes/ParamlistNode.java b/src/ast/nodes/ParamlistNode.java
index 144eb13..0a9696f 100644
--- a/src/ast/nodes/ParamlistNode.java
+++ b/src/ast/nodes/ParamlistNode.java
@@ -10,6 +10,7 @@ import ast.types.*;
  * Node for the `param_list` statement of the grammar.
  */
 public class ParamlistNode implements Node {
+
     private ArrayList<Node> params;
 
     public ParamlistNode(ArrayList<Node> _params) {
@@ -27,6 +28,10 @@ public class ParamlistNode implements Node {
         return errors;
     }
 
+    public int getParamNumber() {
+        return params.size();
+    }
+
     @Override
     public Type typeCheck() {
         return new VoidType();
-- 
cgit v1.2.3-18-g5258


From afff6a80cd58f7787efa1398f7c8cbdce8989323 Mon Sep 17 00:00:00 2001
From: geno <gabriele.genovese2@studio.unibo.it>
Date: Sun, 30 Jun 2024 13:36:37 +0200
Subject: fixed warnings, better formatting, final added where possible

---
 src/ast/nodes/ParamlistNode.java | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

(limited to 'src/ast/nodes/ParamlistNode.java')

diff --git a/src/ast/nodes/ParamlistNode.java b/src/ast/nodes/ParamlistNode.java
index 0a9696f..cf75d08 100644
--- a/src/ast/nodes/ParamlistNode.java
+++ b/src/ast/nodes/ParamlistNode.java
@@ -1,17 +1,16 @@
 package ast.nodes;
 
+import ast.types.*;
 import java.util.ArrayList;
-
 import semanticanalysis.SemanticError;
 import semanticanalysis.SymbolTable;
-import ast.types.*;
 
 /**
  * Node for the `param_list` statement of the grammar.
  */
 public class ParamlistNode implements Node {
 
-    private ArrayList<Node> params;
+    private final ArrayList<Node> params;
 
     public ParamlistNode(ArrayList<Node> _params) {
         params = _params;
@@ -19,7 +18,7 @@ public class ParamlistNode implements Node {
 
     @Override
     public ArrayList<SemanticError> checkSemantics(SymbolTable ST, int _nesting) {
-        ArrayList<SemanticError> errors = new ArrayList<SemanticError>();
+        ArrayList<SemanticError> errors = new ArrayList();
 
         for (var param : params) {
             errors.addAll(param.checkSemantics(ST, _nesting));
-- 
cgit v1.2.3-18-g5258